Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of the kalman estimator rate #1301

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

krichardsson
Copy link
Contributor

@krichardsson krichardsson commented Jul 4, 2023

A float is used to compute the next time the prediction should run. When the system tick is larger than 0x2000000, the float operation gets rounding errors and the interval becomes too short.
The problem is observed after 9 hours and 20 minutes of up time and the symptom is a warning in the console log that the prediction rate is too high (around 125 Hz).
This PR fixes the problem by not using a float.

@tobbeanton tobbeanton self-requested a review July 4, 2023 09:31
@krichardsson krichardsson merged commit e56b7fd into master Jul 4, 2023
23 checks passed
@krichardsson krichardsson deleted the krichardsson/estimator-rate branch July 4, 2023 09:41
@knmcguire knmcguire added this to the next-release milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants